Chore: Make sure implicit thumbnail in higher priority over the thumbnail source #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiborBatek
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
I have captured multiple thumbnails on different publish instances and all publishes well. No any failures or errors shown during publishing and only Review takes precedence over user based thumbnail which is correct behavior.
and integrated on Ayon server:
All good imho!
moonyuet
deleted the
bugfix/AY-5562_Maya-duplicate-thumbnail-integration-error
branch
64qam
added
the
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from ynput/ayon-core#695
Changelog Description
Resolve #9
When users trying to create screengrab thumbnails and publish along with the review product type, it will error out the intgerate.py due to the duplicate of the thumbnail representation data. This PR is to make sure the extract thumbnail is always at the higher priority than the extract thumbnail sources
Additional info
please test on some other hosts with thumbnail extractors in review family, maybe similar bug is hit when you publish both screengrab and review family
Testing notes:
Launch Maya/Max
Create Review Instance
Create Screengrab in publisher tab
Publish