Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Executable path expand user and standard env var #1095

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Tilix4
Copy link
Contributor

@Tilix4 Tilix4 commented Jan 17, 2025

Changelog Description

Executable path expand user ~ and standard environment variables syntax $ENV_VAR.

Additional info

Fix #1091

Testing notes:

  1. In Applications addon, add a ~ or $ENV_VAR (don't forget to set it at some point) to an executable path, like ~/path/to/executable or $HOME/path/to/executable (Unix syntax)

@ynbot ynbot added the size/XS label Jan 17, 2025
@Tilix4
Copy link
Contributor Author

Tilix4 commented Jan 21, 2025

NB: I figured out this path resolving isn't processed when launching the application (clicking on the icon). I'd love to contribute in the appropriate place, but I cannot figure the full stack of calls. I only managed to understand that the application path is set when this function is called, but I don't get what is calling it: https://github.com/ynput/ayon-harmony/blob/b96d3155712855a78b8006ad2e02690b7d17777e/client/ayon_harmony/api/lib.py#L84

@iLLiCiTiT
Copy link
Member

NB: I figured out this path resolving isn't processed when launching the application (clicking on the icon).

I think it is. But harmony integration wraps harmony process under ayon-launcher process running launch_script.py which will then launch the application. But the executable path is resolved the same way as others in ayon-applications addon inside ayon_applications/defs.py .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow more flexibility in executable path resolving
3 participants