Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-6854_GUI: Settings tab always defaults to Production #831

Open
jm22dogs opened this issue Sep 30, 2024 · 1 comment
Open

AY-6854_GUI: Settings tab always defaults to Production #831

jm22dogs opened this issue Sep 30, 2024 · 1 comment
Assignees
Labels
sponsored This is directly sponsored by a client or community member

Comments

@jm22dogs
Copy link

jm22dogs commented Sep 30, 2024

Story

Opening the settings tabs will always load the production variant, instead of keeping the one you were working on previously. This may be dangerous in cases where you are fiddling around with the staging settings, and at some point you change tabs for whatever reason, and when you come back to the settings tab you may think you are still where you left it at (staging settings), but you are now actually happily modifying production settings unaware.

settings_reset_to_production_tab

To reproduce

  1. Click on settings tab, select staging
  2. Click on some other tab
  3. Go back again to the settings tab, you are now in production instead of staging.

Expected behavior

I'd expect the settings variant to stick through sessions.

Environment

  • 1.4.2+202409231943n:
  • Linux:
  • Firefox:

CU Ticket

@jm22dogs jm22dogs added the type: bug Something isn't working label Sep 30, 2024
@m-u-r-p-h-y m-u-r-p-h-y changed the title GUI: Settings tab always defaults to Production AY-6854_GUI: Settings tab always defaults to Production Sep 30, 2024
@m-u-r-p-h-y m-u-r-p-h-y added the sponsored This is directly sponsored by a client or community member label Sep 30, 2024
@Innders
Copy link
Member

Innders commented Sep 30, 2024

@martastain This would probably be quite simple but would require moving the state to the redux store?

@Innders Innders self-assigned this Sep 30, 2024
@Innders Innders linked a pull request Oct 1, 2024 that will close this issue
@mkolar mkolar assigned flynput and unassigned Innders Oct 1, 2024
@mkolar mkolar removed the type: bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member
Projects
None yet
Development

No branches or pull requests

5 participants