Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Asset/Shot LOP use Generic Loader as internal building block #165

Open
1 of 7 tasks
BigRoy opened this issue Nov 7, 2024 · 0 comments
Open
1 of 7 tasks

Load Asset/Shot LOP use Generic Loader as internal building block #165

BigRoy opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@BigRoy
Copy link
Contributor

BigRoy commented Nov 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?

With the Generic Loader implementation now merged it's time to refactor the Load Asset LOP and Load Shot LOP to also use it.

Suggested implementation?

  • Use the Generic Loader internally to Load Asset LOP and Load Shot LOP
  • Add support to still manage the Thumbnail on the "outer node", e.g. using a thumbnail_node parm that thumbnails are applied to that node instead of the generic loader internally. The default value for that parm would then be the node itself. (We could technically spawn of thumbnail also into a separate node, but I wouldn't bother with that for now)
  • Make sure LOPs context options still correctly work.
  • Make sure the changes are backwards compatible.
  • The Loader and Scene Inventory (AYON > Load... and AYON > Manage...) should still work and nicely detect them
    • This of course also needs to be backwards compatible with existing LOPs, etc.

Describe alternatives you've considered:

No response

@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

2 participants