Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Remove unused resolver.Resolve() calls #48

Open
Lypsolon opened this issue Sep 19, 2024 · 0 comments
Open

[Enhancement] Remove unused resolver.Resolve() calls #48

Lypsolon opened this issue Sep 19, 2024 · 0 comments
Assignees
@Lypsolon
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@Lypsolon
Copy link
Collaborator

Lypsolon commented Sep 19, 2024 •
edited
Loading

the Layer.ComputeAbsolutePath func should allready resolve all Uris and other path setups so the extra call to Resolve is not neded.

here is an example line.

ayon-usd/client/ayon_usd/standalone/usd/pinning/_pinning_file_generation_funcs.py

Line 196 in a6d604e

resolved_path = resolver.Resolve(layer.ComputeAbsolutePath(identifier))

@Lypsolon Lypsolon added the type: enhancement Improvement of existing functionality or minor addition label Sep 19, 2024
@Lypsolon Lypsolon self-assigned this Sep 19, 2024
@Lypsolon Lypsolon changed the title Your issue title here [ Enhancement] Remove unused resolver.Resolve() calls Sep 23, 2024
@Lypsolon Lypsolon changed the title [ Enhancement] Remove unused resolver.Resolve() calls [Enhancement] Remove unused resolver.Resolve() calls Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lypsolon Lypsolon

Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lypsolon