-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide dedicated error for "Could not connect to lakeFS" #62
Comments
There are better options im sure but what we could do is the following. we first
this gives us the HTTP status code back and is fast enough.
|
The status check response is very good - it may be good that if a status code comes back that is not positive that we ALWAYS report that as the exception for clarity? (Unless we know more specifics about the error than the status code, if so we could then of course provide an even better exception) Anyway, what does |
this is what it returns when the URL is wrong.
this is the return if its correct. not 100% sure how we best use it. i guess we can check if an md table exists ?
last option would be to use the rest api with python requests. that might be a bit better in terms of error reporting quality. |
Ah, no - this is perfect. When the URL is wrong and when it can't connect due to authentication - both those errors seem 'clear' to me. They report what failed in likely the best way The So TL;DR - it's just a matter of passing on the errors from lakectl if errors occur? |
yes the last one is the success "status" we just need to correctly detect it but that should not be to hard i think. |
No, don't do that - don't make it bigger than it is. We need to find the hardest 'critical' failure cases which is the user having the wrong server OR the wrong lakeFS API keys (I think the latter will be most common for new users) |
[Reference Info] |
Please describe the feature you have in mind and explain what the current shortcomings are?
Currently it's hard to identify whether a resolver timestamp missing on LakeFS or any USD lib items unable to be found on the LakeFS server are because it can't connect to the server or whether the matching resolver doesn't exist on the LakeFS repository. Hence, the logs we generate are unclear regarding whether it failed to connect due to any of:
How would you imagine the implementation of the feature?
Get a connection status to the repo itself, detect whether it's able to access the server, whether it's able to login or not, etc. and report accordingly. This will make it easier to debug the issue that users might face.
[Child Issues]
The text was updated successfully, but these errors were encountered: