Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed build pipline. error: logger log lvl set in an outdated way #12

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

Lypsolon
Copy link
Collaborator

The development branch has two bugs in the create_package.py and manage.sh respectively.

manage.sh is calling create_package.py with the -v flag; this option is no longer available and can be removed.
create_package.py tries to create the logger instance with the log level parameter, but that needs to be done via setLevel()

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but code changes make sense.

The bugs being fixed also match the report on Ynput discord here

@Lypsolon Lypsolon merged commit bd87bd9 into develop Jun 21, 2024
1 check passed
@Lypsolon Lypsolon deleted the bugfix/create_script_manage branch September 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants