Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField resets on orientation change #993

Closed
nicolarevelant opened this issue Sep 25, 2024 · 5 comments
Closed

TextField resets on orientation change #993

nicolarevelant opened this issue Sep 25, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@nicolarevelant
Copy link

nicolarevelant commented Sep 25, 2024

Problem: when I perform this sequence of events the TextField resets:

  1. Enter the password
  2. Rotate the device twice

or (if it's the first time):

  1. Create new password
  2. Rotate the device twice

Possible solution:

/app/src/main/java/com/yogeshpaliyal/keypass/ui/auth/AuthScreen.kt:41 use rememberSaveable instead of remember

Screenshots:

Version:

1.4.29 (1429) - not fixed in 1.4.30

@yogeshpaliyal
Copy link
Owner

Thank you for raising this issue, would you like to work on this issue?

@yogeshpaliyal yogeshpaliyal added the good first issue Good for newcomers label Dec 4, 2024
@aritra-tech
Copy link
Contributor

Hey @yogeshpaliyal i want to work on this issue

@yogeshpaliyal
Copy link
Owner

Sure @aritra-tech , Assigning this to you.

@aritra-tech
Copy link
Contributor

Created a PR for this issue @yogeshpaliyal
#1074

@yogeshpaliyal
Copy link
Owner

Thank you @aritra-tech for your valuable contribution. ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants