Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop extend airbnb config #25

Open
5 tasks
RusinovAnton opened this issue Feb 20, 2018 · 4 comments
Open
5 tasks

Stop extend airbnb config #25

RusinovAnton opened this issue Feb 20, 2018 · 4 comments

Comments

@RusinovAnton
Copy link
Contributor

We had spent some time yesterday working on code together using Eslint and have noticed that there are plenty rules that we want to override or disable at all. Its been decided to move from extended config to our own set of rules which we will be able to tweak easily.

Plan of attack:

  • decide which rules should be changed (WIP):
    • disable rules:
      ...
    • reconfigure rules:
      ...
  • make flat "base" and "react" shareable configs from airbnb packages
  • change eslint-plugin-yola to use these configs.

@yola/frontend-engineering I propose to discuss rules that should be disabled/reconfigured before proceed on changing this plugin.

@eugeneford
Copy link

@RusinovAnton, @yola/frontend-engineering, i guess the first one that we should either refuse or reconfigure are import/extensions and import/no-unresolved

@RusinovAnton
Copy link
Contributor Author

RusinovAnton commented Feb 20, 2018

Regarding import/extension, there is ignorePackages setting will be added in next release

https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md#examples

No estimated date; it will be released as soon as I have time to do so.
import-js/eslint-plugin-import#976 (comment)

@eugeneford
Copy link

eugeneford commented Feb 20, 2018

In our https://github.com/yola/ws-headless-builder/blob/master/webpack.config.js we have a consistent configuration that allows us to resolve imports like:

import project from 'src/project';

And this is a canonic way to import/use modules in ws-headless-builder. Its allows us to ommit large ugly relative paths

@RusinovAnton
Copy link
Contributor Author

@eugeneford webpack alias vs eslint import plugin issue can be resolved by adding specialized setting into .eslintrc.js

AtomLinter/linter-eslint#610 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants