Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup sometimes goes off screen (mobile) #1634

Open
shiki-tm opened this issue Dec 1, 2024 · 0 comments
Open

Popup sometimes goes off screen (mobile) #1634

shiki-tm opened this issue Dec 1, 2024 · 0 comments
Labels
kind/bug The issue or PR is regarding a bug

Comments

@shiki-tm
Copy link

shiki-tm commented Dec 1, 2024

Another old but great bug that sometimes happens on yomitan mobile is that the popup can go out of bounds, making it unseeable. It seems to be affected by either the height of the popup and or the gap between a word and the popup. 2 years ago when i would find the popup going off the top or bottom edge, I learned I could reduce the height of the popup and that would make it seeable again, specifically for that word inside of TTU reader and it would be fine, for some time. But this just kept happening and I continued shrinking the popup until for awhile it's been pretty good. I thought this must've been something special to ttu because I didn't see it happen somewhere else but I didn't use that many other websites with vertical text tbh.

Then recently with Chinese I've been using asbplayer with YouTube to immerse in kiwi browser (yes its enjoyable) but I found the popup while horizontal, to be even smaller because of the popup/text offset setting so I returned that back to 0 and the popup is now of decent size but I guess that brought back the possibility of this bug and I actually saw the popup off to the top edge, unseeable. Now I know it's not just TTU and I guess it's not only a bug on vertical text. I don't think having to constantly mess with the size and popup offset is normal so it's probably a bug.

You can see just the popup header at the top of this pic.this has been happening somewhat often since I reduced the text offset from 50 to 0 on my Chinese profile like 2 weeks ago.
Screenshot_20241201_002059_Kiwi Browser

But to reproduce it you need like a specific example I imagine so just the other day I found it in the 1st chapter title of a Chinese book. I modified by adding images to the chapters so I just checked and it can only be replicated on this version, if you need the epub I can upload here or wherever, sorry about that but this is the most obvious and specific example I have now.

Thank you
yomitan-settings-2024-12-01-06-24-00.json

@shiki-tm shiki-tm added the kind/bug The issue or PR is regarding a bug label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

No branches or pull requests

1 participant