From 814eea70d78cb21f776178f4b9e22c1be6eb3b45 Mon Sep 17 00:00:00 2001 From: Darius Jahandarie Date: Wed, 1 Jan 2025 10:47:55 +0900 Subject: [PATCH] fix playwright --- .github/workflows/playwright.yml | 3 --- .github/workflows/playwright_comment.yml | 8 ++++++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 357178f1c..8a5c64af1 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -91,20 +91,17 @@ jobs: - name: "[PR] Store steps.master-screenshots.outcome in a file" run: echo ${{ steps.master-screenshots.outcome }} > ./master-screenshots-outcome - if: github.event_name == 'pull_request' - uses: actions/upload-artifact@v4 with: name: master-screenshots-outcome-${{ matrix.shardIndex }} path: master-screenshots-outcome - if: github.event_name == 'pull_request' - uses: actions/upload-artifact@v4 with: name: playwright-output-${{ matrix.shardIndex }} path: playwright-output retention-days: 1 - if: github.event_name == 'pull_request' playwright: timeout-minutes: 60 diff --git a/.github/workflows/playwright_comment.yml b/.github/workflows/playwright_comment.yml index 8a32d4ad7..cd6611da2 100644 --- a/.github/workflows/playwright_comment.yml +++ b/.github/workflows/playwright_comment.yml @@ -36,6 +36,14 @@ jobs: run_id: ${{ github.event.workflow_run.id }} name: master-screenshots-outcome + - name: Grab playwright-results-json from PR run + uses: dawidd6/action-download-artifact@80620a5d27ce0ae443b965134db88467fc607b43 # v7 + continue-on-error: true + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + run_id: ${{ github.event.workflow_run.id }} + name: playwright-results-json + - name: Dry-run grab playwright-report from PR run so we have its ID uses: dawidd6/action-download-artifact@80620a5d27ce0ae443b965134db88467fc607b43 # v7 id: playwright-report