Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent remote-change event in RealtimeSyncOff mode #823

Closed
chacha912 opened this issue May 27, 2024 · 0 comments · Fixed by #824
Closed

Prevent remote-change event in RealtimeSyncOff mode #823

chacha912 opened this issue May 27, 2024 · 0 comments · Fixed by #824

Comments

@chacha912
Copy link
Contributor

What happened:

In the RealtimeSyncOff mode, the remote-change event is triggered unexpectedly. Previously, in #758, the remote-change event was prevented in the pushonly mode, and a similar solution is needed for the RealtimeSyncOff mode.

What you expected to happen:

Remote change events should not occur in RealtimeSyncOff mode.

How to reproduce it (as minimally and precisely as possible):

This issue occurs when switching from pushpull mode to RealtimeSyncOff mode before receiving a response to the sync request.

Anything else we need to know?:

Environment:

  • Operating system:
  • Browser and version:
  • Yorkie version (use yorkie version):
  • Yorkie JS SDK version:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants