Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a plan to add support for windows ? #117

Open
edwinjhlee opened this issue May 11, 2024 · 7 comments
Open

Is there a plan to add support for windows ? #117

edwinjhlee opened this issue May 11, 2024 · 7 comments
Labels
idea any new ideas or suggestions OS-Windows Issue is related to windows only, and doesn't affect Linux/Mac

Comments

@edwinjhlee
Copy link

Is your feature request related to a problem? Please describe.

We are developing x-cmd, we would like to collect the portable cross-platform command tools.
Take broot for example: https://x-cmd.com/pkg/broot

Describe the solution you'd like

Add support to windows

Describe alternatives you've considered

Additional context

Thank you.

@edwinjhlee edwinjhlee added the idea any new ideas or suggestions label May 11, 2024
@yorukot
Copy link
Owner

yorukot commented May 11, 2024

charmbracelet/lipgloss#30
So the reason why I said it is not supported before is because it will cause layout problems when I test it on pwsh in Windows (other file operations etc... do not have big problems)

I just found this and it seems to solve this problem. I will test the function in the next few weeks to see if there are any problems and let you know!

@yorukot
Copy link
Owner

yorukot commented May 13, 2024

Update for install on windows #130

@edwinjhlee
Copy link
Author

Very quick ... 👍

Once you decide it is mature, and provide release with cross platform build.
Send me a notice in this issue, we will package your build into our package system.

BTW, we x-cmd release 0.3.6 with some AI/LLM demo, you might probably have interests.
https://x-cmd.com

@lazysegtree
Copy link
Collaborator

@yorukot At this point it is pretty stable in windows too. At least I am using it on powershell, and not seeing layout problems. Although I see that are many open issues that are specific to windows.

#332
#380
#383
#437
#514
#544

What do you think should be the criteria for considering it ready for windows ?

@yorukot
Copy link
Owner

yorukot commented Jan 24, 2025

Currently I'm actually not sure if it's stable on Windows (I don't use Windows) so I'm not sure of the current status, but as you said it seems to be usable at the moment. I will close this issue first.

@yorukot yorukot closed this as completed Jan 24, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in superfile todo list Jan 24, 2025
@lazysegtree
Copy link
Collaborator

I would suggest lets wait for a few critical windows related issues to be fixed. I did use it in windows, it works fine, though file operations are mostly broken.

Ctrl D not working

#380

'e' or 'E' does not works.

#437

Paste not working

#514
#552

I have a windows VM in MacOS that I use for testing. I would try to perform some more testing after these issues are fixed. And then we can consider it ready for windows.

Reopening it for now.

@lazysegtree lazysegtree reopened this Jan 24, 2025
@lazysegtree lazysegtree added the OS-Windows Issue is related to windows only, and doesn't affect Linux/Mac label Jan 27, 2025
@lazysegtree
Copy link
Collaborator

lazysegtree commented Jan 27, 2025

@edwinjhlee @yorukot
I have created this milestone for tracking stable windows support. https://github.com/yorukot/superfile/milestone/1

Once this is completed and we perform release of a newer version super file, I think we can mark this as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea any new ideas or suggestions OS-Windows Issue is related to windows only, and doesn't affect Linux/Mac
Projects
Status: Done
Development

No branches or pull requests

4 participants
@edwinjhlee @lazysegtree @yorukot and others