Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for Windows Terminal #2

Closed
bjorg opened this issue Mar 11, 2020 · 6 comments
Closed

Icon for Windows Terminal #2

bjorg opened this issue Mar 11, 2020 · 6 comments
Assignees
Labels
feature request New feature or request

Comments

@bjorg
Copy link

bjorg commented Mar 11, 2020

For the next release, maybe include the below PNG as an AWS-icon.png file. That way it could easily be added to the Windows Terminal profile.

AWS-icon

Here's also an example for the Windows Profile itself.

{
    "guid": "{3dffc929-1f2e-44cc-8253-9635e0298f6b}",
    "hidden": false,
    "name": "Amazon Linux 2",
    "commandline": "wsl.exe -d Amazon2",
    "startingDirectory" : "C:\\",
    "icon": "C:\\Amazon2\\AWS-icon.png"
}
@yosukes-dev
Copy link
Owner

Since AmazonWSL uses wsldl, installation-related functions depend on wsldl.
So you need to open the feature request on wsldl, not AmazonWSL.

@bjorg
Copy link
Author

bjorg commented Mar 11, 2020

It doesn't need to be installed. Just part of the zip would be good enough.

@yosukes-dev
Copy link
Owner

OK.
Does that mean just including images as an option, right?
If so, you need to make sure that the original icon itself can be redistributed with the same license as the Amazon Linux distribution.

@bjorg
Copy link
Author

bjorg commented Mar 12, 2020

Yes. I'll do some research.

@bjorg
Copy link
Author

bjorg commented Mar 12, 2020

This one is very similar and has a free license:
http://www.iconarchive.com/show/simple-icons-by-danleech/aws-icon.html

The original I proposed requires a link back. Maybe in the ReadMe?
http://www.iconarchive.com/show/socialmedia-icons-by-uiconstock/AWS-icon.html

@yosukes-dev
Copy link
Owner

yosukes-dev commented Mar 12, 2020

The second one looks better.
I will add it and update README.md.

@yosukes-dev yosukes-dev added the feature request New feature or request label Mar 12, 2020
@yosukes-dev yosukes-dev self-assigned this Mar 12, 2020
yosukes-dev added a commit that referenced this issue Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants