Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0 #55

Open
Weishaupt opened this issue Oct 30, 2024 · 4 comments

Comments

@Weishaupt
Copy link
Contributor

Hey @yous,

I've just upgraded my bundle to all latest versions. Now I see some deprecation warnings w.r.t. whiteglass.

Deprecation Warning: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

@import "whiteglass";

The first warning is related to the description on how to customize whiteglass

The other warnings are from whiteglass.scss

// Import partials.
@import
  "whiteglass/base",
  "whiteglass/layout",
  "whiteglass/syntax-highlighting"
;

Two further deprecation warnings are related to adjust-color()

Deprecation Warning: Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.
Use color.adjust instead.

@yous
Copy link
Owner

yous commented Oct 31, 2024

Hi @Weishaupt,

Recently whiteglass v1.11.6 tried to replace lighten and darken with color.adjust, but #54 occurred. In Jekyll < 4, which is used by default github-pages gem (github/pages-gem#813), there is no @use and color.adjust (https://sass-lang.com/documentation/modules/color/#adjust).

The latest sass-embedded is 1.80.5, so I think we can pin sass-embedded to < 3 in 1.11.x releases for Jekyll < 4, and make 1.12.x releases with newer syntaxes for Jekyll >= 4.

@Weishaupt
Copy link
Contributor Author

Hey @yous,

this sounds like a good idea. Would you create a new branch for 1.12 then to be able to maintain releases for both branches, or just be done with 1.11?

@yous
Copy link
Owner

yous commented Nov 4, 2024

I'm thinking about this:

  • 1.x for Jekyll < 4
    • 1.11.x for current state and disable warnings that will be deprecated in Dart Sass 3.0.0
    • 1.12, 1.13, ... for whiteglass' new features
  • 2.x for Jekyll >= 4
    • 2.0 when Dart Sass 3.0.0 is released
    • 2.1, 2.2, ... for whiteglass' new features

When Dart Sass 3.0.0 is released, master will bump to 2.0, and I'll make 1.x branch for Jekyll < 4.

@yous
Copy link
Owner

yous commented Nov 4, 2024

jekyll-sass-converter recently added feature that can specify silence_deprecations option, but a new version has not been released.

You can specify gem 'sass-embedded', '< 1.80' to disable warnings temporarily. When next version of jekyll-sass-converter is released, you can add the following lines to _config.yml:

sass:
  silence_deprecations: [import, global-builtin]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants