From 9d2b68a4d695c907ba9531ea806e5ce82f29657e Mon Sep 17 00:00:00 2001 From: cobalt-github-releaser-bot <95661244+cobalt-github-releaser-bot@users.noreply.github.com> Date: Tue, 27 Jun 2023 11:14:12 -0700 Subject: [PATCH] Cherry pick PR #739: Fix memory leak where ref to JS callback was not being deleted (#740) b/288915945 Change-Id: Ibc3f9d4e3a1457fbc4f57645d3073a521338f0d2 (cherry picked from commit 7b88f37d2059485ee18983835156e7aa89bc8f81) Co-authored-by: Joel Martinez --- cobalt/h5vcc/h5vcc_metrics.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cobalt/h5vcc/h5vcc_metrics.h b/cobalt/h5vcc/h5vcc_metrics.h index 675e7e9cecb2..1d3a5ec30a79 100644 --- a/cobalt/h5vcc/h5vcc_metrics.h +++ b/cobalt/h5vcc/h5vcc_metrics.h @@ -77,7 +77,7 @@ class H5vccMetrics : public script::Wrappable { const cobalt::h5vcc::H5vccMetricType& metric_type, const std::string& serialized_proto); - h5vcc::MetricEventHandlerWrapper* uploader_callback_ = nullptr; + scoped_refptr uploader_callback_; std::unique_ptr run_event_handler_callback_;