From cae93f94b1ca24ed05d23e3c2ec4a44046c2210f Mon Sep 17 00:00:00 2001 From: Holden Warriner Date: Mon, 7 Aug 2023 13:22:34 -0400 Subject: [PATCH] Remove starboard:gn_all dep on crashpad/handler (#1125) After Cobalt 23 we want the crashpad_handler binary to always be built with the native target toolchain, and never with Starboard. With this PR, the ninja files for the Starboard-based target will no longer be generated. b/270858365 Change-Id: I3d206468bbf2385a79506c164b68b6ee98d97982 --- starboard/BUILD.gn | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/starboard/BUILD.gn b/starboard/BUILD.gn index 610e6acec962..977f95353af5 100644 --- a/starboard/BUILD.gn +++ b/starboard/BUILD.gn @@ -66,15 +66,7 @@ group("gn_all") { deps += [ "//third_party/lz4_lib:lz4" ] if (sb_is_evergreen_compatible) { - deps += [ - "//third_party/crashpad/client", - - # TODO(b/270858365): remove this dependency on the Starboard-based - # target (from the target toolchain) once Buildbot is using the native - # target (from native_target toolchain) and no longer declares the - # Starboard-based one as a build target. - "//third_party/crashpad/handler", - ] + deps += [ "//third_party/crashpad/client" ] data_deps = [ "//starboard/loader_app", "//third_party/crashpad/handler:crashpad_handler(//$starboard_path/toolchain:native_target)",