Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SbImage APIs #1791

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Deprecate SbImage APIs #1791

merged 1 commit into from
Oct 16, 2023

Conversation

gbournou
Copy link
Contributor

b/304882604

@gbournou
Copy link
Contributor Author

The EG failure will be worked around via #1792

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1791 (92c0181) into main (896a0ec) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
+ Coverage   57.57%   57.65%   +0.08%     
==========================================
  Files        1906     1901       -5     
  Lines       94789    94594     -195     
==========================================
- Hits        54573    54538      -35     
+ Misses      40216    40056     -160     
Files Coverage Δ
cobalt/loader/image/image_decoder.cc 72.97% <100.00%> (-5.49%) ⬇️
starboard/decode_target.h 40.00% <ø> (-3.75%) ⬇️
starboard/elf_loader/exported_symbols.cc 98.56% <ø> (-0.02%) ⬇️

... and 13 files with indirect coverage changes

@kaidokert kaidokert merged commit 70449dd into youtube:main Oct 16, 2023
352 of 355 checks passed
@gbournou gbournou deleted the image branch January 8, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants