From a4dadc8e0515d3dccf0fc250e65f0a3a759934db Mon Sep 17 00:00:00 2001 From: Niranjan Yardi Date: Fri, 2 Aug 2024 14:28:26 -0700 Subject: [PATCH] Use same debug symbol configuration for win and xb1 (#3921) b/302741384 This adds pdb's for debugging locally for win32 --- starboard/win/shared/platform_configuration/BUILD.gn | 3 +++ starboard/xb1/platform_configuration/BUILD.gn | 4 ---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/starboard/win/shared/platform_configuration/BUILD.gn b/starboard/win/shared/platform_configuration/BUILD.gn index 3c1d545036e22..ec9ec17da0986 100644 --- a/starboard/win/shared/platform_configuration/BUILD.gn +++ b/starboard/win/shared/platform_configuration/BUILD.gn @@ -47,6 +47,9 @@ config("platform_configuration") { # Suppress import library warning caused by the win32/posix_emu "/ignore:4286", ] + if (is_qa || is_gold || !cobalt_fastbuild) { + ldflags += [ "/DEBUG:FASTLINK" ] + } if (cobalt_pending_clean_up) { # TODO: b/330363799 - These were added for the base/net update and should diff --git a/starboard/xb1/platform_configuration/BUILD.gn b/starboard/xb1/platform_configuration/BUILD.gn index 6dfe2337f1ee1..10b82842bef2a 100644 --- a/starboard/xb1/platform_configuration/BUILD.gn +++ b/starboard/xb1/platform_configuration/BUILD.gn @@ -60,10 +60,6 @@ config("target") { ] } - if (is_qa || is_gold || !cobalt_fastbuild) { - ldflags += [ "/DEBUG:FASTLINK" ] - } - ldflags += [ "/NODEFAULTLIB" ] arflags += [ "/NODEFAULTLIB" ] libs += [