Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Mask Support #40

Open
atul161 opened this issue May 26, 2021 · 6 comments
Open

Field Mask Support #40

atul161 opened this issue May 26, 2021 · 6 comments

Comments

@atul161
Copy link

atul161 commented May 26, 2021

In case of fieldmask (inside proto message) incorrect graphql file generated.

@ysugimoto
Copy link
Owner

Does it mean the omit field option could not work?
FYI: https://github.com/ysugimoto/grpc-graphql-gateway/blob/master/include/graphql/graphql.proto#L177

@atul161
Copy link
Author

atul161 commented Jun 7, 2021

Hi @ysugimoto ,
As we know there are multiple standard protofiles provided by Google currently which is open source.
Some of are empty protobuf , timestamp etc.
In similar way Google also standardized a proto file which is called Field Mask.
You may read about this https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/field_mask.proto

So , currently your package doesn't generate file when we use fieldmask inside protocol buffer.

@atul161
Copy link
Author

atul161 commented Jun 7, 2021

I think you need to add suport in ptypes.
https://github.com/ysugimoto/grpc-graphql-gateway/tree/master/ptypes

@ysugimoto
Copy link
Owner

Thanks, I didn't know that ptype.
https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/field_mask.proto describes its spec and I looked at it.

The spec mentions about oneof, but currently, this package does not support oneof field, therefor we may need to implement oneof spec first.

@atul161
Copy link
Author

atul161 commented Jun 7, 2021

Will you work upon oneOf field or will I sent you a PR?

@ysugimoto
Copy link
Owner

ysugimoto commented Jun 8, 2021

I appreciate it if you make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants