You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently components are written in a way that it is hard to understand updating flow and not break something.
Component manager ask their status and sets main resource state and invokes sync of the component, while components are deciding if they should be syncing or not based on main resource state, other component states and list of updating components. Moreover there is large update flow with several sub-states, which is also checked by components to decide if they should recreate pods or launch jobs.
The code can be refactored in a way, that Component Manager would decide what (one at a time) component needs to be updated and component would update itself completely that without checking state/substate (this goes along nicely with linear flow feature). This would make both manager and components code easier to understand and less error-prone.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Currently components are written in a way that it is hard to understand updating flow and not break something.
Component manager ask their status and sets main resource state and invokes sync of the component, while components are deciding if they should be syncing or not based on main resource state, other component states and list of updating components. Moreover there is large update flow with several sub-states, which is also checked by components to decide if they should recreate pods or launch jobs.
The code can be refactored in a way, that Component Manager would decide what (one at a time) component needs to be updated and component would update itself completely that without checking state/substate (this goes along nicely with linear flow feature). This would make both manager and components code easier to understand and less error-prone.
Beta Was this translation helpful? Give feedback.
All reactions