From 6c731208b9238095265f03c7444175418e5f3f85 Mon Sep 17 00:00:00 2001
From: Jacob Wujciak-Jens <jacob@wujciak.de>
Date: Tue, 17 Dec 2024 15:55:17 -0800
Subject: [PATCH] build(ci): Fix build metrics report (#11839)

Summary:
Changes to finding GTest caused the build metrics job to fail as we don't have GTest in the image yet. See https://github.com/facebookincubator/velox/issues/11837

Pull Request resolved: https://github.com/facebookincubator/velox/pull/11839

Reviewed By: Yuhta

Differential Revision: D67347290

Pulled By: kgpai

fbshipit-source-id: a52f090cd6757b78204d4cbfd893834b7b314148
---
 .github/workflows/build-metrics.yml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build-metrics.yml b/.github/workflows/build-metrics.yml
index 2a3285e2f6ac..4838da650c8d 100644
--- a/.github/workflows/build-metrics.yml
+++ b/.github/workflows/build-metrics.yml
@@ -47,10 +47,6 @@ jobs:
     defaults:
       run:
         shell: bash
-    env:
-      VELOX_DEPENDENCY_SOURCE: SYSTEM
-      simdjson_SOURCE: BUNDLED
-      xsimd_SOURCE: BUNDLED
     steps:
       - uses: actions/checkout@v4
         with:
@@ -121,7 +117,6 @@ jobs:
             "/tmp/metrics"
 
   upload-report:
-    if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'facebookincubator/velox' }}
     permissions:
       contents: write
     runs-on: ubuntu-latest
@@ -156,6 +151,13 @@ jobs:
           cd scripts/bm-report
           nix-shell --run "quarto render report.qmd"
 
+      - name: Upload Report Artifact
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3
+        with:
+          name: report
+          path: scripts/bm-report/report.html
+          retention-days: 5
+
       - name: Push Report
         # The report only uses conbench data from 'main'
         # so any data generated in a PR won't be included