Skip to content

Commit 15e3696

Browse files
ddl-ebrownyubofredwang
authored andcommitted
Fix flyte-core rendering when flyteagent enabled (flyteorg#4922)
- Flyte agent now tries to render a specific set of podLabels, so assumes that there is an empty `podLabels: {}` set. This change to values.yaml for flyte-core ensures empty values are there. - Fixes: Error: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at <include "flyteagent.podLabels" .>: error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels Signed-off-by: ddl-ebrown <[email protected]>
1 parent 6754b2f commit 15e3696

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

charts/flyte-core/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ helm install gateway bitnami/contour -n flyte
194194
| flyteagent.enabled | bool | `false` | |
195195
| flyteagent.plugin_config.plugins.agentService.defaultAgent.endpoint | string | `"dns:///flyteagent.flyte.svc.cluster.local:8000"` | |
196196
| flyteagent.plugin_config.plugins.agentService.defaultAgent.insecure | bool | `true` | |
197+
| flyteagent.podLabels | object | `{}` | Labels for flyteagent pods |
197198
| flyteconsole.affinity | object | `{}` | affinity for Flyteconsole deployment |
198199
| flyteconsole.enabled | bool | `true` | |
199200
| flyteconsole.ga.enabled | bool | `false` | |

charts/flyte-core/values.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,8 @@ flyteagent:
279279
defaultAgent:
280280
endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
281281
insecure: true
282+
# -- Labels for flyteagent pods
283+
podLabels: {}
282284

283285
#
284286
# FLYTEPROPELLER SETTINGS

0 commit comments

Comments
 (0)