[DocDB] Fix lock-order-inversion found by test PgDdlAtomicityTest.TestDatabaseGC

[mdbridge]

Jira Link: DB-15497

Description

TSAN reports (one of many):

[m-1] WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock) (pid=478487)
[m-1]   Cycle in lock order graph: M0 (0x7b600013e808) => M1 (0x7b600013ec08) => M0
[m-1] 
[m-1]   Mutex M1 acquired here while holding mutex M0 in main thread:
[m-1]     #0 <null> <null> (0x000000000042)
[m-1] 
[m-1]   Mutex M0 previously acquired by the same thread here:
[m-1]     #0 <null> <null> (0x000000000042)
[m-1] 
[m-1]   Mutex M0 acquired here while holding mutex M1 in thread T50:
[m-1]     #0 pthread_mutex_lock ${YB_LLVM_TOOLCHAIN_DIR}-build/src/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:1339:3 (yb-master+0xa352b)
[m-1]     #1 std::mutex::lock() <null> (libc++.so.1+0xa7749)
[m-1]     #2 yb::RWCLock::WriteLock() ${YB_SRC_ROOT}/src/yb/util/rwc_lock.cc:149:16 (libyb_util.so+0x412aaf)
[m-1]     #3 yb::CowObject<yb::master::PersistentTableInfo>::StartMutation() ${YB_SRC_ROOT}/src/yb/util/cow_object.h:77:11 (libmaster.so+0x604789)
[m-1]     #4 yb::CowWriteLock<yb::master::PersistentTableInfo>::CowWriteLock(yb::CowObject<yb::master::PersistentTableInfo>*) ${YB_SRC_ROOT}/src/yb/util/cow_object.h:229:11 (libmaster.so+0x604789)
[m-1]     #5 yb::master::MetadataCowWrapper<yb::master::PersistentTableInfo>::LockForWrite() ${YB_SRC_ROOT}/src/yb/master/catalog_entity_base.h:87:37 (libmaster.so+0x604789)
[m-1]     #6 yb::master::CatalogManager::DeleteYsqlDBTables(string const&, yb::master::DeleteYsqlDBTablesType, yb::master::LeaderEpoch const&) ${YB_SRC_ROOT}/src/yb/master/catalog_manager.cc:9374:23 (libmaster.so+0x604789)
[m-1]     #7 yb::master::CatalogManager::DeleteYsqlDatabaseAsync(scoped_refptr<yb::master::NamespaceInfo>, yb::master::LeaderEpoch const&) ${YB_SRC_ROOT}/src/yb/master/catalog_manager.cc:9224:14 (libmaster.so+0x5fe363)
[m-1] 
[m-1]   Mutex M1 previously acquired by the same thread here:
[m-1]     #0 pthread_mutex_lock ${YB_LLVM_TOOLCHAIN_DIR}-build/src/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:1339:3 (yb-master+0xa352b)
[m-1]     #1 std::mutex::lock() <null> (libc++.so.1+0xa7749)
[m-1]     #2 yb::RWCLock::WriteLock() ${YB_SRC_ROOT}/src/yb/util/rwc_lock.cc:149:16 (libyb_util.so+0x412aaf)
[m-1]     #3 yb::CowObject<yb::master::PersistentTableInfo>::StartMutation() ${YB_SRC_ROOT}/src/yb/util/cow_object.h:77:11 (libmaster.so+0x604789)
[m-1]     #4 yb::CowWriteLock<yb::master::PersistentTableInfo>::CowWriteLock(yb::CowObject<yb::master::PersistentTableInfo>*) ${YB_SRC_ROOT}/src/yb/util/cow_object.h:229:11 (libmaster.so+0x604789)
[m-1]     #5 yb::master::MetadataCowWrapper<yb::master::PersistentTableInfo>::LockForWrite() ${YB_SRC_ROOT}/src/yb/master/catalog_entity_base.h:87:37 (libmaster.so+0x604789)
[m-1]     #6 yb::master::CatalogManager::DeleteYsqlDBTables(string const&, yb::master::DeleteYsqlDBTablesType, yb::master::LeaderEpoch const&) ${YB_SRC_ROOT}/src/yb/master/catalog_manager.cc:9374:23 (libmaster.so+0x604789)
[m-1]     #7 yb::master::CatalogManager::DeleteYsqlDatabaseAsync(scoped_refptr<yb::master::NamespaceInfo>, yb::master::LeaderEpoch const&) ${YB_SRC_ROOT}/src/yb/master/catalog_manager.cc:9224:14 (libmaster.so+0x5fe363)

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

• I confirm this issue does not contain any sensitive information.