Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] Refactor yb_disable_transactional_writes code path #26166

Open
1 task done
huapengy opened this issue Feb 23, 2025 · 0 comments
Open
1 task done

[YSQL] Refactor yb_disable_transactional_writes code path #26166

huapengy opened this issue Feb 23, 2025 · 0 comments
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@huapengy
Copy link
Contributor

huapengy commented Feb 23, 2025

Jira Link: DB-15499

Description

We are accessing yb_disable_transactional_writes directly in many code path. One stack:

@        ybcModifyTable.c  YBCExecuteInsertIndexForDb
@        ybcModifyTable.c  YBCExecuteInsertIndex
@        0x1045d8d5b  ybcininsert
@        0x1044ecb2f  index_insert
@        execIndexing.c  YbExecDoInsertIndexTuple
@        copyfrom.c  ExecInsertIndexTuples
@        0x104747f3f  CopyFrom

In the cases we need to change yb_disable_transactional_writes value dynamically in code, we may forget to restore back. Better to refactor the code to pass an argument like YbcPgTransactionSetting through the stack.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@huapengy huapengy added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Feb 23, 2025
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Development

No branches or pull requests

2 participants