Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size on tablet and display value of selected color #24

Open
DevMash opened this issue Mar 12, 2017 · 2 comments
Open

Size on tablet and display value of selected color #24

DevMash opened this issue Mar 12, 2017 · 2 comments

Comments

@DevMash
Copy link

DevMash commented Mar 12, 2017

Hi,

thanks for this nice color picker. Though we still got some problems with it :)
We need the user to be able to set the color by providing a hex value, is it somehow possible to do this with this picker?
For example: User wants to set the color with hex-value #fe6b7b - Is this somehow possible with this picker?

Another point that we found is the size of the colorpicker on tablets. Is there any way to adjust the picker on tablets? This is how the picker looks on tablet

If its currently not possible to do these settings, is it somehow possible to contribute?

Thanks in advance.
Kind regards,
Manuel

@denisk20
Copy link
Collaborator

Hi Manuel,
Initializing the picker from a hex value is totally possible, you'll need to provide some kind of UI (a TextView for instance) for the user to enter the hex value, parse that value and convert it into an int and then initialize the dialog with this value using one of constructors both of which accept int color:
https://github.com/yukuku/ambilwarna/blob/master/library/src/main/java/yuku/ambilwarna/AmbilWarnaDialog.java#L47.
As for your second question, the size of the dialog indeed doesn't scale well on tablets, although on my nexus 7 it doesn't look as bad as you've shown. This is definitely something worth improving, and contributions would be very welcome.

@DevMash
Copy link
Author

DevMash commented Apr 14, 2017

Hi Denis,

I forked the project. I have changed the layout to work with bigger screens and added a hex field into the picker. The hex field is always there (not configurable). Feel free to pick the commit.

Kind regards,
Manuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants