Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HellPot desperately needs test cases #139

Open
yunginnanet opened this issue Feb 1, 2024 · 1 comment · May be fixed by #163
Open

HellPot desperately needs test cases #139

yunginnanet opened this issue Feb 1, 2024 · 1 comment · May be fixed by #163
Assignees
@yunginnanet
Labels
CI/CD enhancement New feature or request
Milestone
v1

Comments

@yunginnanet
Copy link
Owner

I am absolutely thrilled to see the participation rising on this repo, but it really starts to bring something to light about HellPot:

there are no test cases

the solution is simple1: write tests

Footnotes

  1. half joking here; since this is an app vs a lib, proper test coverage tends to be slightly more of a challenge ↩
@yunginnanet yunginnanet self-assigned this Feb 1, 2024
@yunginnanet yunginnanet added enhancement New feature or request CI/CD labels Feb 1, 2024
@yunginnanet yunginnanet added this to the v0.5 milestone Feb 1, 2024
@yunginnanet yunginnanet pinned this issue Feb 1, 2024
@yunginnanet yunginnanet mentioned this issue Feb 2, 2024
Merged
yunginnanet added a commit that referenced this issue Jun 21, 2024
@yunginnanet
Chore: prune deps
843d04a 
Tacking this on to trigger github issue notifs:

Related to pull request GH-162:
closes #140
closes #139
@yunginnanet yunginnanet mentioned this issue Jun 21, 2024
Closed
yunginnanet added a commit that referenced this issue Jun 26, 2024
@yunginnanet
Chore: prune deps
8597a30 
Tacking this on to trigger github issue notifs:

Related to pull request GH-162:
closes #140
closes #139
yunginnanet added a commit that referenced this issue Jun 26, 2024
@yunginnanet
Chore: prune deps
f6b4e2a 
Tacking this on to trigger github issue notifs:

Related to pull request GH-162:
closes #140
closes #139
yunginnanet added a commit that referenced this issue Jun 26, 2024
@yunginnanet
Chore: prune deps
a09adb6 
Tacking this on to trigger github issue notifs:

Related to pull request GH-162:
closes #140
closes #139
@yunginnanet yunginnanet linked a pull request Jun 26, 2024 that will close this issue
Draft
@yunginnanet
Copy link
Owner Author

yunginnanet commented Jul 3, 2024 •
edited
Loading

Related: we need to build some sort of realistic measurement apparatus. Likely we'll want to emulate running the application and have a second process read from the http endpoint, possibly measuring the rate of hellfire via https://github.com/yunginnanet/Rate5/tree/main/speedometer

Related discussion exists in #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunginnanet yunginnanet

Labels
CI/CD enhancement New feature or request
Projects
None yet
Milestone
v1
1 participant
@yunginnanet