Feature/add buildscript #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolestar
reviewed
Aug 29, 2017
| value: "info" | ||
|
|
||
| - name: VXNETS | ||
| value: "vxnet-2xj9lrp,vxnet-h00g66q" |
There was a problem hiding this comment.
这个实际部署的时候怎么去变更呢？或者也从 configmap 读取？
There was a problem hiding this comment.
#21 如果有多个容器共用一些配置用configmap会更方便。这里只是一个示例。用户可以按需求定制。我觉得在k8s app里可以改成用configmap的。
|
hostnic client 怎么更新呢？也可以考虑放到镜像中，启动的时候 copy 到主机上。 |
|
暂时先让客户下载。我去看看有没有可能加到k8s镜像里面。 如果对于app来说，其实无所谓放在哪。对于普通用户不希望给主机留下变更。#22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add docker file and fix "executable not found" issue