Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No ability to detect tcp server failure #260

Open
KnicKnic opened this issue Jan 21, 2020 · 0 comments · May be fixed by #263
Open

No ability to detect tcp server failure #260

KnicKnic opened this issue Jan 21, 2020 · 0 comments · May be fixed by #263
Milestone
0.9.0

Comments

@KnicKnic
Copy link
Contributor

There is no programatic way to detect if a tcp server is failed. If creating a load balancer ontop of dhcp addresses you can lose your address temporarily (and have it renewed), or permanently. It would be nice if the server indicated that it was faulted.

I think it is reasonable if there needs to be a tear down and a recreation of the server. However I would like a signal indicating that it is necessary to do so.

In the below code you can see that the go routine exits without signaling failure (it does log).

gobetween/src/server/tcp/server.go

Lines 272 to 282 in 7d8a736

go func() {
for {
conn, err := this.listener.Accept()
if err != nil {
log.Error(err)
return
}
go this.wrap(conn, sniEnabled)
}

In my scenario this is related to #246 , however one could easily have the same issue when communicating to the server via rest.
@KnicKnic KnicKnic linked a pull request Jan 24, 2020 that will close this issue
Open
@illarion illarion added this to the Selected for development milestone Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Add channel that signals server is completed KnicKnic/gobetween
2 participants
@illarion @KnicKnic