-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patchers apply to other game modes. #18
Comments
Session with expected behaviour:
Session with unexpected behaviour:
It looks like sometimes the profile gets selected after the deferred modules are loaded, and usually before. I'm supplying the profile on the command line (I'm launching zEdit from MO2, so I know for certain what profile I want to load). |
This doesn't fix why it's not working, but it does make the problem go away without restarting repeatedly: this.reloadPatchers = function() {
let patcherIds = patchers.map(patcher => patcher.info.id);
patchers = [];
patcherIds.forEach(id => {
let patcherPath = fh.jetpack.path(`modules\\${id}`);
moduleService.loadModule(patcherPath);
});
+ this.updateForGameMode();
};
this.updateForGameMode = function(gameMode) {
+ if (gameMode) this.gameMode = gameMode;
+ if (this.gameMode) gameMode = this.gameMode;
patchers = patchers.filter(patcher => {
return patcher.gameModes.includes(gameMode);
});
}; |
I've got a patcher that supports only gmFO4, but it is allowed to (attempt, and fail) to be applied to gmSSE and gmTES5.
I figure it should either be hidden entirely, given that it does not apply to the game mode at all, or it should be marked in red, similar to the patchers that do not have their required mods installed.
The text was updated successfully, but these errors were encountered: