-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volta (JS toolchains as code) #552
Conversation
Adds cowboyd/zsh-volta (program) and OMZP::volta (completions). Signed-off-by: sebastian <[email protected]>
Merging to
|
Signed-off-by: sebastian <[email protected]>
Signed-off-by: sebastian <[email protected]>
# usually completions are located at $HOME/.zi/completions | ||
zi wait'0b' lucid for \ | ||
blockf has'volta' \ | ||
atinit'ZSH_CACHE_DIR=$ZI[HOME_DIR]' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Reviewer:
The completions plugin OMZP::volta searches for the completion file to be located at $ZSH_CACHE_DIR/completions/_volta
.
As (at least on my system) ZSH_CACHE_DIR
was not defined (maybe a oh-my-zsh variable?), we set the variable to the directory, where the completions
are stored, ZI[HOME_DIR]
.
My question is, does this work for other users as well? Where are their completions located?
I found these options:
- Use
ZI[CACHE_DIR]
instead ofZI[HOME_DIR]
to be compatible with theZSH_CACHE_DIR
variable the plugins asks for. This did not work on my system, because the variable was not set and therefore the completions plugin could not find a completions directory under that location. - (preferred) Use
ZI[COMPLETIONS_DIR]
, but this expands to/home/user/.zi/completions
and is therefore not compatible with the pathOMZP::volta
expects the completion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question is, does this work for other users as well? Where are their completions located?
This is a good question.
It's only 14 lines of code for simple tasks and is done poorly.
- The volta completion plugin actually is function.
- Variable
ZSH_CACHE_DIR
shouldn't be hardcoded in this situation. - It should follow standards or be reasonable.
We can't include such a plugin in our wiki as an example. I should have a solution for this in the upcoming weekend.
Sorry for the late response. Zi can't tell that it is a completion as I mentioned previously. |
Don't feel any pressure on this, I'm happy that you take a look. |
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions! |
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions! |
Pull Request closed and locked due to lack of activity. If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986 Then open a new PR, referencing this closed PR in your message. |
Adds cowboyd/zsh-volta (program) and OMZP::volta (completions) for volta.