Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor datasets #11

Open
zaccharieramzi opened this issue Oct 3, 2019 · 2 comments
Open

Refactor datasets #11

zaccharieramzi opened this issue Oct 3, 2019 · 2 comments
Labels
data Something data related enhancement New feature or request good first issue Good for newcomers

Comments

@zaccharieramzi
Copy link
Owner

Oasis and fastMRI sequences have a lot in common.

To ease as much as possible the integration of other databases, the common backbone of these sequences should be extracted, and the current classes re-implemented.
@zaccharieramzi zaccharieramzi added the enhancement New feature or request label Oct 3, 2019
@zaccharieramzi
Copy link
Owner Author

As we will try to move on to tf datasets for the acceleration they provide, this will be soon changed to refactor datasets!

@zaccharieramzi zaccharieramzi added the good first issue Good for newcomers label Feb 11, 2020
@zaccharieramzi zaccharieramzi changed the title Refactor sequences Refactor datasets Mar 4, 2020
@zaccharieramzi
Copy link
Owner Author

zaccharieramzi commented Mar 4, 2020 •
edited
Loading

We should not only refactor datasets, but also get rid of the use of sequences for example when doing inference in the validation notebooks.

@zaccharieramzi zaccharieramzi added the data Something data related label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data Something data related enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaccharieramzi