Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some testing #15

Open
facundofarias opened this issue Jul 26, 2014 · 3 comments
Open

Add some testing #15

facundofarias opened this issue Jul 26, 2014 · 3 comments

Comments

@facundofarias
Copy link

Just an idea, but some test would be good as usage documentation.

@zachlatta
Copy link
Owner

When you say tests, are you thinking something along the lines
of full-on integration tests, where emails are actually sent to
a test SMTP server and then verified? Or individual unit tests?

Zach Latta
http://zachlatta.com
https://github.com/zachlatta
https://twitter.com/zachlatta

On Sat, Jul 26, 2014, at 02:43 AM, Facundo Farias wrote:

Just an idea, but some test would be good as usage
documentation.

Reply to this email directly or [1]view it on GitHub.

References

  1. Add some testing #15

@facundofarias
Copy link
Author

Well, the first thought was at least some unit tests.
But, with integration tests would be awesome to test it directly out of the box. What do you think?

@zachlatta
Copy link
Owner

Yeah – completely agree this would be awesome. Apologies for the super slow response time!

Would you be interested in submitting a PR to add some basic tests? Happy to set up a CI to run them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants