From eae54c16c16f4fd056eb663022e646d1e7dd2051 Mon Sep 17 00:00:00 2001
From: wadjih-bencheikh18 <jw_bencheikh@esi.dz>
Date: Wed, 23 Aug 2023 18:01:35 +0100
Subject: [PATCH] refactor: make display and display value independent

---
 src/components/roi/annotation/ConvexHullAnnotation.tsx | 4 ++--
 src/components/roi/annotation/FeretAnnotation.tsx      | 6 ++++--
 src/components/roi/annotation/MBRAnnotation.tsx        | 7 +++----
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/components/roi/annotation/ConvexHullAnnotation.tsx b/src/components/roi/annotation/ConvexHullAnnotation.tsx
index 24b68fd..801eb99 100644
--- a/src/components/roi/annotation/ConvexHullAnnotation.tsx
+++ b/src/components/roi/annotation/ConvexHullAnnotation.tsx
@@ -38,11 +38,11 @@ function ConvexHullAnnotation({ roi }: ConvexHullAnnotationProps) {
     [fontColor, fontSize],
   );
 
-  if (!enabled) return null;
+  if (!enabled && !displayValue) return null;
 
   return (
     <g>
-      <polygon points={svgPoints} style={polygonStyle} />
+      {enabled && <polygon points={svgPoints} style={polygonStyle} />}
       {displayValue && (
         <text x={roi.width / 2} y={roi.height + 1} style={textStyle}>
           {roi.convexHull.surface}
diff --git a/src/components/roi/annotation/FeretAnnotation.tsx b/src/components/roi/annotation/FeretAnnotation.tsx
index 67adff2..322cf48 100644
--- a/src/components/roi/annotation/FeretAnnotation.tsx
+++ b/src/components/roi/annotation/FeretAnnotation.tsx
@@ -53,7 +53,7 @@ function FeretAnnotation({ roi }: FeretAnnotationProps) {
     [fontColor, fontSize],
   );
 
-  if (!enabled) return null;
+  if (!enabled && !displayValue) return null;
 
   return (
     <>
@@ -66,7 +66,9 @@ function FeretAnnotation({ roi }: FeretAnnotationProps) {
             // eslint-disable-next-line react/no-array-index-key
             key={`${roi.id}-${index}`}
           >
-            <line x1={x1} y1={y1} x2={x2} y2={y2} style={lineStyle} />
+            {enabled && (
+              <line x1={x1} y1={y1} x2={x2} y2={y2} style={lineStyle} />
+            )}
             {displayValue && (
               <text
                 x={0}
diff --git a/src/components/roi/annotation/MBRAnnotation.tsx b/src/components/roi/annotation/MBRAnnotation.tsx
index c878f85..7ad9f8a 100644
--- a/src/components/roi/annotation/MBRAnnotation.tsx
+++ b/src/components/roi/annotation/MBRAnnotation.tsx
@@ -36,13 +36,12 @@ function MBRAnnotation({ roi }: MBRAnnotationProps) {
     }),
     [fontColor, fontSize],
   );
-  if (!enabled) {
-    return null;
-  }
+
+  if (!enabled && !displayValue) return null;
 
   return (
     <g>
-      <polygon points={svgPoints} style={polygonStyle} />
+      {enabled && <polygon points={svgPoints} style={polygonStyle} />}
       {displayValue && (
         <text x={roi.width / 2} y={-1} style={textStyle}>
           {roi.width} x {roi.height} ({roi.surface} pixels)