feat: choose between exporting with or without annotations #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pixelium with
|
| Latest commit: |
5865214
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fcab2f67.pixelium.pages.dev |
| Branch Preview URL: | https://119-choose-between-exporting.pixelium.pages.dev |
stropitek
reviewed
Jun 27, 2024
stropitek
reviewed
Jul 1, 2024
stropitek
reviewed
Jul 2, 2024
stropitek
reviewed
Jul 3, 2024
Comment on lines
+97
to
+100
| if (!hasAnnotations) { | ||
| save(); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
My suggestion was not just to remove the effect (it was correct to use an effect in that case), but to move this logic up to the component that handles the export options, which will prevent having to use an effect because then it can be called in an event callback.
| copyToClipboard().catch((error) => | ||
| logger.error(`Failed to copy to clipboard: ${error}`), | ||
| ); | ||
| openExportClipboardModal(); |
There was a problem hiding this comment.
Here in the select callback there can be additional logic to handle the cases where the image has / does not have annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #119
closes #126