Refactor ROIToolbar using react-science PanelHeader #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Deploying with
|
| Latest commit: |
21fb759
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://147a9be2.pixelium.pages.dev |
| Branch Preview URL: | https://53-use-panelheader.pixelium.pages.dev |
stropitek
approved these changes
Aug 22, 2023
|
The header should not scroll and disappear
The header should also be smaller
The cancel / validate should be on the right and closer to each other
If this is not the default preferences in react-science it should be checked why because it is like that in nmrium (but not sure it is coming from react-science). |
No, we're not using them yet in nmruim. |
|
Also in this PR I didn't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #53