Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement surface annotation and improve roi preferences #59

Merged
merged 6 commits into from
Aug 24, 2023

Conversation

wadjih-bencheikh18
Copy link
Contributor

closes : #50

@wadjih-bencheikh18 wadjih-bencheikh18 linked an issue Aug 21, 2023 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 30ba2f9
Status: ✅  Deploy successful!
Preview URL: https://2ac42f75.pixelium.pages.dev
Branch Preview URL: https://50-add-surface-in-pixels-as.pixelium.pages.dev

View logs

@lpatiny
Copy link
Contributor

lpatiny commented Aug 23, 2023

We should make the distinction between just 'show' and 'display value'. We may hide the textual value while still keeping the annotation. Those are 2 different checkboxes.

I would add one more column in front called 'Display' that would show / hide the annotation (indenpendent from the text value)

image

@lpatiny
Copy link
Contributor

lpatiny commented Aug 23, 2023

Displaying surface makes this annotation too slow. The way it is implemented being drawing thousands of little rectangle.
Please unselect the display of the surface by default.
Also by default give another color to ferret diameters.

@wadjih-bencheikh18
Copy link
Contributor Author

I would add one more column in front called 'Display'

if display=false and displayValue=true do we show the textual values?

@lpatiny
Copy link
Contributor

lpatiny commented Aug 23, 2023

Yes

Copy link
Contributor

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be improved in the future because surface annotation is too slow but this is another issue: #60

@lpatiny
Copy link
Contributor

lpatiny commented Aug 24, 2023

@stropitek This PR can be merge for me if the code is ok.
Concerning the check that fails should this be removed with the message of the merge commit ?

@lpatiny lpatiny merged commit bc800a1 into main Aug 24, 2023
@lpatiny lpatiny deleted the 50-add-surface-in-pixels-as-an-annotation-in-the-svg branch August 24, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add surface (in pixels) as an annotation in the SVG
3 participants