Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch components from headlessui or radix to blueprint #469

Open
5 tasks done
targos opened this issue Apr 4, 2023 · 5 comments · Fixed by #734 or #745 · May be fixed by #780
Open
5 tasks done

Switch components from headlessui or radix to blueprint #469

targos opened this issue Apr 4, 2023 · 5 comments · Fixed by #734 or #745 · May be fixed by #780
Assignees
@wadjih-bencheikh18

Comments

@targos
Copy link
Member

targos commented Apr 4, 2023 •
edited by wadjih-bencheikh18
Loading

Tasks
Beta Give feedback
@targos targos mentioned this issue Apr 4, 2023
Closed
@Sebastien-Ahkrin Sebastien-Ahkrin removed their assignment Jul 7, 2023
@targos targos changed the title Switch components from headlessui to radix Switch components from headlessui or radix to blueprint Dec 22, 2023
@targos
Copy link
Member Author

targos commented Dec 22, 2023

@stropitek We should review this.

@stropitek
Copy link
Contributor

stropitek commented Apr 3, 2024 •
edited
Loading

  • Use radix-ui's Collapsible instead of headless-ui's Disclosure
  • Use radix-ui's Select instead of headless-ui's Listbox
  • Remove headlessui depedency

@stropitek
Copy link
Contributor

@wadjih-bencheikh18 can you prioritize this?

@wadjih-bencheikh18 wadjih-bencheikh18 linked a pull request Jun 2, 2024 that will close this issue
469 switch components from headlessui or radix to blueprint #734
Merged
@wadjih-bencheikh18 wadjih-bencheikh18 mentioned this issue Jun 2, 2024
Merged
stropitek added a commit that referenced this issue Jun 12, 2024
@wadjih-bencheikh18 @stropitek
refactor: replace headleassui with radix-ui
d7a0f85 
Refactor InfoPanel and GradientSelector to use radix-ui

Closes: #469

---------

Co-authored-by: Daniel Kostro <[email protected]>
@targos
Copy link
Member Author

targos commented Jun 20, 2024

The components were switched to radix-ui, not to blueprint, so this issue is not finished.

@targos targos reopened this Jun 20, 2024
@wadjih-bencheikh18 wadjih-bencheikh18 mentioned this issue Jul 11, 2024
Merged
@targos targos reopened this Jul 31, 2024
@targos
Copy link
Member Author

targos commented Jul 31, 2024

Still not finished. I can see radix-ui used in:

  • InfoPanel
  • RadioGroup
  • ButtonRadioItem

@wadjih-bencheikh18 wadjih-bencheikh18 linked a pull request Oct 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wadjih-bencheikh18 wadjih-bencheikh18

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@targos @stropitek @Sebastien-Ahkrin @wadjih-bencheikh18