-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] View other trainers Pokémon team & View Pokémon types/weaknesses #36
Comments
Thank you for the suggestions!
I'm interested about this - what value would this provide?
Just to make sure I understand, what is "weakness amount"?
This is currently shown in the applet, but it should be added to the overlay too. |
Added the ability to the overlay with 7835f2f. |
Referencing the above suggestion/commit, I can see value in viewing all pokemon on the opposing team in the cases of when trying to grind the Champion Cup in the end game. It can help users which are less experienced to have an easier time going through it, or even enhance their gameplay experience in general battles outside of it. I could even further suggest the user being able to see the live input of all moves selected during a battle - including their intended slot, but that could prove to be quite difficult to successfully implement. |
As mentioned above, being able to see their full team to help with planning Pokémon in your team
Weakness amount is for example let's pick bulbasaur, if you look at bulbapedia it shows the type effectiveness so it's 2x weak to flying/fire/psychic ice and ½ resistant to fighting/water/electric/fairy and ¼ resistant to grass. That sort of info, if it's possible. Not sure on memory restrictions or if it can be read from the game data.
|
Oh I see - yeah, weakness amount can be calculated. I wouldn't accept multiplayer battle viewing, but I'm not opposed to seeing an NPC's Pokemon. 🙂 |
Oh no definitely not multiplayer battle but NPC teams would be great. Thanks for all the work |
Agreed with the above, many thanks for all the hard work🙃 |
Added initial type match up (weaknesses and strengths) support with 774bf54. |
Type match up support is complete with cfdcb0d |
@zaksabeast wanted to ask, is there any chance that you plan on integrating the battle viewer into the overlay at all? |
@ParlayPartitioner I'm all for adding this feature and may do so in the future, however lately I've been more focused on work and other projects. If anyone wants to get this feature in sooner and open a PR, I'd be happy to accept it. 🙂 |
No problem it's understandable for whenever you have any free time 👍 Hope you're well btw |
@ParlayPartitioner No worries, and I'm doing well (just busy as always!); thanks 😄 I'm tagging this as help wanted. If anyone would like to pick this up, please let me know! |
Happy new year! Is there any chance of there being any spare time to look into this feature update? |
@ParlayPartitioner Happy new year to you as well! I can't make any timeline promises, but I really should implement this. I didn't realize how long it had been since the last comment. 😅 |
Thanks 😄 Haha no worries, had initially forgotten about it myself but thought I'd just check back to check on the status 🤣 Was just curious to see if you would we be willing to/had any spare time ofc |
In the overlay could we view all Pokémon on the other team? Currently "Wild" shows their first mon,
Also, for those of us who haven't played in a while, viewing type as well as the Pokémon weakness amount would be helpful too.
Maybe if the info is available, abilities too?
Thanks!
The text was updated successfully, but these errors were encountered: