Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] View other trainers Pokémon team & View Pokémon types/weaknesses #36

Open
pekempy opened this issue Mar 22, 2020 · 16 comments
Open
Labels
discussion There's an idea up for discussion enhancement New feature or request help wanted Extra attention is needed

Comments

@pekempy
Copy link

pekempy commented Mar 22, 2020

In the overlay could we view all Pokémon on the other team? Currently "Wild" shows their first mon,

Also, for those of us who haven't played in a while, viewing type as well as the Pokémon weakness amount would be helpful too.

Maybe if the info is available, abilities too?

Thanks!

@zaksabeast zaksabeast added discussion There's an idea up for discussion enhancement New feature or request labels Mar 23, 2020
@zaksabeast
Copy link
Owner

Thank you for the suggestions!

In the overlay could we view all Pokémon on the other team?

I'm interested about this - what value would this provide?

viewing type as well as the Pokémon weakness amount would be helpful too

Just to make sure I understand, what is "weakness amount"?

Maybe if the info is available, abilities too?

This is currently shown in the applet, but it should be added to the overlay too.

@zaksabeast
Copy link
Owner

Added the ability to the overlay with 7835f2f.

@ParlayPartitioner
Copy link

Referencing the above suggestion/commit, I can see value in viewing all pokemon on the opposing team in the cases of when trying to grind the Champion Cup in the end game. It can help users which are less experienced to have an easier time going through it, or even enhance their gameplay experience in general battles outside of it.

I could even further suggest the user being able to see the live input of all moves selected during a battle - including their intended slot, but that could prove to be quite difficult to successfully implement.

@pekempy
Copy link
Author

pekempy commented Mar 31, 2020

View all Pokémon in the opposing trainers team.

As mentioned above, being able to see their full team to help with planning Pokémon in your team

Weakness amount.

Weakness amount is for example let's pick bulbasaur, if you look at bulbapedia it shows the type effectiveness so it's 2x weak to flying/fire/psychic ice and ½ resistant to fighting/water/electric/fairy and ¼ resistant to grass. That sort of info, if it's possible. Not sure on memory restrictions or if it can be read from the game data.

Ability added to overlay
Thank you 😀

@zaksabeast
Copy link
Owner

Oh I see - yeah, weakness amount can be calculated.

I wouldn't accept multiplayer battle viewing, but I'm not opposed to seeing an NPC's Pokemon. 🙂

@pekempy
Copy link
Author

pekempy commented Apr 1, 2020

Oh no definitely not multiplayer battle but NPC teams would be great.
Weakness amount would be fab, good luck fitting it all on screen ha 😅

Thanks for all the work

@ParlayPartitioner
Copy link

Agreed with the above, many thanks for all the hard work🙃

@zaksabeast
Copy link
Owner

Added initial type match up (weaknesses and strengths) support with 774bf54.

@zaksabeast
Copy link
Owner

Type match up support is complete with cfdcb0d

@ParlayPartitioner
Copy link

@zaksabeast wanted to ask, is there any chance that you plan on integrating the battle viewer into the overlay at all?

@zaksabeast
Copy link
Owner

@ParlayPartitioner I'm all for adding this feature and may do so in the future, however lately I've been more focused on work and other projects.

If anyone wants to get this feature in sooner and open a PR, I'd be happy to accept it. 🙂

@ParlayPartitioner
Copy link

No problem it's understandable for whenever you have any free time 👍
I wish I was good enough to help open a PR with code, so can't help out there rip 😕

Hope you're well btw

@zaksabeast
Copy link
Owner

@ParlayPartitioner No worries, and I'm doing well (just busy as always!); thanks 😄

I'm tagging this as help wanted. If anyone would like to pick this up, please let me know!

@zaksabeast zaksabeast added the help wanted Extra attention is needed label Jul 1, 2020
@ParlayPartitioner
Copy link

Happy new year! Is there any chance of there being any spare time to look into this feature update?

@zaksabeast
Copy link
Owner

@ParlayPartitioner Happy new year to you as well!

I can't make any timeline promises, but I really should implement this. I didn't realize how long it had been since the last comment. 😅

@ParlayPartitioner
Copy link

Thanks 😄 Haha no worries, had initially forgotten about it myself but thought I'd just check back to check on the status 🤣 Was just curious to see if you would we be willing to/had any spare time ofc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion There's an idea up for discussion enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants