-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapting PSGAN to 1D - Questions #3
Comments
Hi to answer briefly most of your questions: When using affine waves, the waves can be tilted any angle towards the axes (e.g. 0.5X + 0.5Y for a 45 degree wave). In the 1D case, you do not have these X and Y, so the code will simplify a bit. Each wave will be only X*w , where w is parameters for the frequency. I hope this helps you and wish you good luck with your project. |
Thank you for your clarifications ! I want to apply the PSGAN for the generation of amorphous atomic structures. These structures exhibit similar properties to textures : local correlations that are randomly and smoothly continued through space. I am still unsure about whether this is the best way to represent N points in 3 dimensions, as the spatial correlations are less evident than in the case of an image. |
@massimilianocomin Hi, I think it would be better to use 3D convolution than 1D with 3 channel, too much spatial information is lost in this 1D setting. |
Hello,
I am adapting your model to
1D
data, without any global dimension (i.e. the equivalent of a single1D
texture). I am confused about periodic part of the noise tensor and the periodic layer :Why initialize last wave parameter (the only one when no global dimensions) to 0 and 1 ?
Why are even indices on the periodic dimension initialized in a way (a matrix with all the same columns) and odd indices with the transposed matrix ? (lines 59-65 in psgan.py)
What does the
periodic_affine
parameter control ? (I see, in the case of no global dimensions, that there will be a mixture between even and odd parts of the periodic noise tensor controlled by additional wave parameters, but why?)I believe in
1D
this parameter would not make sense, am I correct ?Since a line of code is worth a thousand words, see below my modification of the relevant functions (note that I am working in python3) for the case where
dg = 0
and for1D
data (with channels of course).And the calculation done by the periodic layer would be :
So the periodic part of the noise tensor would span over
nz_periodic
channels instead of2 * nz_periodic
in the2D
case.Let me know if you find anything wrong !
Thank you !
The text was updated successfully, but these errors were encountered: