Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm dependency instead op github link #16

Open
Remco75 opened this issue Nov 15, 2016 · 7 comments
Open

Use npm dependency instead op github link #16

Remco75 opened this issue Nov 15, 2016 · 7 comments
Labels

Comments

@Remco75
Copy link

Remco75 commented Nov 15, 2016

In the package.json you use the following link:
"json-schema-ref-parser": "github:zallek/json-schema-ref-parser#v1",
To a very old version of your own module.

Could you just link to the regular release on npm?

Reason: my compagny's build system uses an internal npm-repo, and can't handle the external github links... :-(

would be great if you could fix this

@Remco75
Copy link
Author

Remco75 commented Nov 15, 2016

btw, I can make a PR if you want, just gimme a sign

@zallek
Copy link
Owner

zallek commented Nov 18, 2016

json-schema-ref-parser is a dependency of swagger-parser, the main lib used to parse swagger files.
Though, swagger-parser requires json-schema-ref-parser: ^1.4.1 (even in their last version)

And the 1.4.1 includes bugs they fixed in their v2 but don't want to fix in their v1.
Please refer to::
APIDevTools/json-schema-ref-parser#11
APIDevTools/json-schema-ref-parser#12

That's the purpose of my fork, 2 commits fixing some issues while fetching a swagger file over internet https://github.com/zallek/json-schema-ref-parser/commits/

@Remco75
Copy link
Author

Remco75 commented Nov 20, 2016

ok, I get the problem. Will ask the guys from swagger-parser to update their libs in that case. Maybe I can help out there :-)

@zallek
Copy link
Owner

zallek commented Nov 20, 2016

yeh if you can, would be great :)

@stephanmullerNL
Copy link

@Remco75 Did you ever end up asking the guys from swagger-parser? Can't find an open issue about it.

@zallek
Copy link
Owner

zallek commented Jan 31, 2017

@Remco75 @picodealion any news?
as you can see on my previous comment I did try to make them fix in their v1 but they didn't want to. Maybe you could add 👍 in APIDevTools/json-schema-ref-parser#11 and APIDevTools/json-schema-ref-parser#12 to help ?

@stt19
Copy link

stt19 commented Feb 27, 2019

It looks like the latest version of swagger-parser: ^6.0.5 uses json-schema-ref-parser: ^6.0.3.

If you are still working on the tool and are able to get rid of the github dependency, that'd be awesome! Great looking tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants