Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Al/refactor comparisons #2054

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Al/refactor comparisons #2054

merged 1 commit into from
Feb 27, 2025
+1,235 −798

Conversation

agnesLeroy
Copy link
Contributor

closes: please link all relevant issues

PR content/description

Check-list:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Relevant issues are marked as resolved/closed, related issues are linked in the description
  • Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

@cla-bot cla-bot bot added the cla-signed label Feb 12, 2025
@agnesLeroy agnesLeroy force-pushed the al/refactor_comparisons branch from 4e19ee1 to f5a0565 Compare February 25, 2025 08:36
@agnesLeroy agnesLeroy marked this pull request as ready for review February 25, 2025 08:37
@agnesLeroy agnesLeroy force-pushed the al/refactor_comparisons branch 5 times, most recently from 6871218 to dd11754 Compare February 26, 2025 16:53
bbarbakadze
bbarbakadze reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@bbarbakadze bbarbakadze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks Agnes.

@agnesLeroy agnesLeroy force-pushed the al/refactor_comparisons branch from dd11754 to dbb1d09 Compare February 27, 2025 08:29
@agnesLeroy agnesLeroy force-pushed the al/refactor_comparisons branch from dbb1d09 to 04d11d8 Compare February 27, 2025 09:04
@zama-bot zama-bot removed the approved label Feb 27, 2025
@agnesLeroy agnesLeroy force-pushed the al/refactor_comparisons branch from 04d11d8 to 18941c4 Compare February 27, 2025 09:41
@zama-bot zama-bot removed the approved label Feb 27, 2025
@agnesLeroy agnesLeroy force-pushed the al/refactor_comparisons branch from 18941c4 to 0ca2a98 Compare February 27, 2025 12:12
@zama-bot zama-bot removed the approved label Feb 27, 2025
@agnesLeroy agnesLeroy merged commit 1d7f9f1 into main Feb 27, 2025
98 of 101 checks passed
@agnesLeroy agnesLeroy deleted the al/refactor_comparisons branch February 27, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarbakadze bbarbakadze bbarbakadze approved these changes

Assignees
No one assigned
Labels
approved cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agnesLeroy @bbarbakadze @zama-bot