test: make the bound on the base variance check a bit looser #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen failures, we need proper confidence intervals on these tests
|
There's a formula of the variance of the variance estimation: https://math.stackexchange.com/a/73080 I'm not sure it's worth spending time using it for computing this intervals |
mayeul-zama
approved these changes
Feb 24, 2025
|
a better fix could be to allow the result to be smaller, while keeping a tight bound when it's bigger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp solution to a check that is too strict (and in that case the obtained value was actually smaller than expected which is good)
@mayeul-zama do we have proper intervals for those checks ?