Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Things arguments #153

Open
kronosapiens opened this issue Mar 8, 2024 · 0 comments
Open

Reorganize Things arguments #153

kronosapiens opened this issue Mar 8, 2024 · 0 comments
Labels
maintenance Improving existing functionality maybe A potential update things Related to the Things app

Comments

@kronosapiens
Copy link
Member

Current invocation seems a bit awkward:

await Things.buyThing(HOUSE, rice.id, RESIDENT1, now, GENERAL, 10, 1);

The order here is house, thing, resident, time, account, price, and quantity.

Explore visual / semantic improvements. Perhaps:

await Things.buyThing(HOUSE, RESIDENT1, GENERAL, rice.id, 10, 1, now);

Attempt to go from more general to more specific. Here we have house, resident, account, thing, price, quantity, and time.

@kronosapiens kronosapiens added things Related to the Things app maintenance Improving existing functionality maybe A potential update labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improving existing functionality maybe A potential update things Related to the Things app
Projects
None yet
Development

No branches or pull requests

1 participant