Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] ToCs are empty or incomplete, wasting screen real estate #2149

Closed
sneakers-the-rat opened this issue Sep 2, 2024 · 3 comments
Closed

Comments

@sneakers-the-rat
Copy link
Contributor

sneakers-the-rat commented Sep 2, 2024

(raising this here as requested in #2142 )

All these comments are based on current version of v3 docs: https://zarr.readthedocs.io/en/v3/index.html

Currently on the each page (using the tutorial for example here), the primary sidebar is totally empty or contains a single item. on wide screens, this is sort of a curiosity, but it becomes a nuisance on narrower screens. More than anything is just looks weird and unfinished (not your fault, byproduct of the theme)

Wider than medium breakpoint:
Screenshot 2024-08-30 at 2 41 44 PM

Below medium breakpoint:
Screenshot 2024-08-30 at 2 42 10 PM

There is also a related problem where the "index" pages within a section don't appear like indices, eg. https://zarr.readthedocs.io/en/v3/getting_started.html contains an "installation" subpage, but the main body of the page doesn't make that obvious.

The basic issue is that pydata-sphinx-theme has a specific notion of sections that has a double nesting of section -> sectiontoc -> localtoc, where each of the sections (eg. "getting started," "tutorials," etc.) is expected to contain a number of other subpages, but currently they all only contain a single page.

One answer is to just remove the left sidebar ( #2142 ), another is to move the in-page toc to the left sidebar (also described in #2142 ), or thirdly one could split up the content of the sections into multiple pages.

We have experienced this double nav being confusing in other projects that use pydata-sphinx-theme (eg. pyOpenSci/python-package-guide#267 ), because the norm is to only have one navbar, and the right sidebar collapses at medium widths and isn't obvious on mobile, where you get two menu bars to choose from:

Screenshot 2024-09-02 at 12 16 33 PM
@d-v-b
Copy link
Contributor

d-v-b commented Sep 2, 2024

Thanks for raising this issue, I agree that that empty left navbar is unsightly.

because the norm is to only have one navbar

At least for the doc sites I frequent, I think the double navbar is fairly common -- see the numpy docs or pydantic docs or tensorstore. Those projects make it work, so I think the zarr-python docs are just doing it wrong, and my proposed solution would be to re-organize the docs so that we use both navbars properly.

@sneakers-the-rat
Copy link
Contributor Author

At least for the doc sites I frequent, I think the double navbar is fairly common

totally ya, sorry what i wrote is slightly off what i meant - with those projects the scale is slightly different, where there are tons of pages so you expect to use the topbar for global navigation between sections, leftbar for navigation between pages within sections, rightbar for within page. so maybe closer is 'expectation is to have a hierarchy of navs s.t. the in-page toc becomes more obvious when the between-page tocs are obvious'

@jhamman
Copy link
Member

jhamman commented Sep 13, 2024

closed by #2142

@jhamman jhamman closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants