-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only support tuple[int, int] for ByteRangeRequest
s
#2567
Comments
I would be glad to work on this if helpful. |
thanks for opening this issue! I think always using a non-negative int for the start of a byte range will work, but I'm not sure about the end -- I suspect |
Ah, this actually brings up a third scenario which might also motivate typing of tuple[int, int | None]. The ObjectStore PR supports a suffix request with the length indicated by a negative start value. Local store seems to support this as well, with an additional possibility of a negative end value. So in both cases negative values indicate the number of bytes from the end of the file. FsspecStore does not seem to support this. I was really surprised to discover |
We should minimize surprises here, so I would support normalizing our byte range convention to match what people expect |
Darn, I'm sorry that I missed that this is a duplicate of #2437. Let's continue any discussion there. |
this also holds for
zarr-python
-- I think we currently useNone
and0
to express the same thing, which should be fixed.Originally posted by @d-v-b in #1661 (comment)
Based on this discussion,
None
should not be supported as thestart
orend
forByteRangeRequest
s.The text was updated successfully, but these errors were encountered: