Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .info_complete a property? #2600

Closed
dstansby opened this issue Dec 30, 2024 · 3 comments
Closed

Make .info_complete a property? #2600

dstansby opened this issue Dec 30, 2024 · 3 comments

Comments

@dstansby
Copy link
Contributor

I noticded that there's a new info_complete method, which looks super neat! I find it a bit confusing that .info is a property, but .info_completeis a method though.

Would it be worth changing info_complete to a property to match? Or info to a method to match info_complete?

@jhamman
Copy link
Member

jhamman commented Jan 4, 2025

@TomAugspurger will likely be able to give the best reasoning for why we landed on a method. IIRC, it had to do with signaling that info_complete would trigger (potentially expensive) IO.

@TomAugspurger
Copy link
Contributor

That's correct. info is a property for backwards compatibility. info_complete does I/O, so I wanted it to be awaitable.

@dstansby
Copy link
Contributor Author

dstansby commented Jan 4, 2025

👍 makes sense, thanks for clarifying!

@dstansby dstansby closed this as completed Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants