Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement activation handling flawed #192

Open
pascalzauberzeug opened this issue Oct 7, 2024 · 1 comment
Open

Implement activation handling flawed #192

pascalzauberzeug opened this issue Oct 7, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@pascalzauberzeug
Copy link
Contributor

While reviewing #190, I noticed that the state-handling of implements is neither coherent nor working correctly.

All implements know whether they are activated or not and that state can be changed by Implement.activate and Implement.deactivate. They are however not used by the base navigation class, but called by the navigations that extend each other, which leads to activate being called multiple times at different stages of the preparation process.

Additionally WeedingImplent tracks it's own state which should not be the case. Especially because it's never stopped after being started.

When updating the KPIs, implements should either check if they are active or not. Or maybe better not handle the KPIs at all and let the KPI-provider do that.

@pascalzauberzeug pascalzauberzeug added bug Something isn't working help wanted Extra attention is needed labels Oct 7, 2024
@Johannes-Thiel
Copy link
Contributor

With the changes that are Introduced in #190 the interenal statetracker was removed and the KPI function was moved to the base class. The check if the Impement is working is against the active property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants