Merge pull request #1570 from dabenny/patch-1

Resize method for ui.echart
zauberzeug · Sep 18, 2023 · 035f059 · 035f059
2 parents 5662357 + 58cbedd
commit 035f059
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/nicegui/elements/echart.js b/nicegui/elements/echart.js
@@ -3,24 +3,17 @@ export default {
   mounted() {
     this.chart = echarts.init(this.$el);
     this.chart.setOption(this.options);
-    this.chart.resize();
+    new ResizeObserver(this.chart.resize).observe(this.$el);
   },
   beforeDestroy() {
-    this.destroyChart();
+    this.chart.dispose();
   },
   beforeUnmount() {
-    this.destroyChart();
+    this.chart.dispose();
   },
   methods: {
     update_chart() {
-      if (this.chart) {
-        this.chart.setOption(this.options);
-      }
-    },
-    destroyChart() {
-      if (this.chart) {
-        this.chart.dispose();
-      }
+      this.chart.setOption(this.options);
     },
   },
   props: {