Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when ui.dark_mode breaks Tailwind #3994

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Show warning when ui.dark_mode breaks Tailwind #3994

merged 2 commits into from
Nov 18, 2024

Conversation

falkoschindler
Copy link
Contributor

As discussed in #3753, ui.dark_mode can break Tailwind styling if used on a page with dark=None

@ui.page('/', dark=None)
def page():
    ui.dark_mode(True)
    ui.label('This should be bordered').classes('border')

or with ui.run(dark=None).

This PR shows a warning in this situation. I won't link it with the issue because this isn't a proper fix.

@rodja rodja merged commit 7eaaded into main Nov 18, 2024
7 checks passed
@rodja rodja deleted the dark-conflict branch November 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants